[Drbd-dev] drbd0: [drbd0_receiver/5740] sock_sendmsg time expired, ko = 4294967294

[Montrose, Ernest]

Hi all,
It seems that the mdev->ko_count counter is going negative as evidenced by the following message:
drbd0: [drbd0_receiver/5740] sock_sendmsg time expired, ko = 4294967294
 
Note the rather large ko value.
 STATIC we_should_drop_the_connection(drbd_dev *mdev, struct socket *sock) is the place we decrement this unconditionnaly. Should at least be this:
Index: drbd/drbd_main.c
===================================================================
--- drbd/drbd_main.c    (revision 14981)
+++ drbd/drbd_main.c    (working copy)
@@ -1549,7 +1549,7 @@
        if (drop_it)
                return TRUE;
-       drop_it = !--mdev->ko_count;
+       drop_it = !mdev->ko_count || !--mdev->ko_count;
        if ( !drop_it ) {
                ERR("[%s/%d] sock_sendmsg time expired, ko = %u\n",
                       current->comm, current->pid, mdev->ko_count);

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.linbit.com/pipermail/drbd-dev/attachments/20070610/f67e6bc4/attachment.html