[DRBD-user] drbdmanage-proxmox v2.0

Roland Kammerer roland.kammerer at linbit.com
Wed Sep 27 10:31:28 CEST 2017

Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.

On Wed, Sep 27, 2017 at 08:24:39AM +0200, Frank Rust wrote:
> Hi Roland,
> I just installed the latest version of drbdmanage-proxmox (2.1-1) and tried a "Move Disk" to drbdstorage.
> Result is:
> (…)
> >  "." is not a valid unit!
> usage: drbdmanage add-volume [-h] [-m MINOR] [-d DEPLOY] [-s SITE] name size
> (…)
> I debugged a bit and it shows the following command to be executed:
> Exec cmd( $VAR1 = [
> '/usr/bin/drbdmanage',
> 'new-volume',
> 'vm-1018-disk-1',
> '10.015625'
> ];
> )
> I think you should re-think the size calculation to be more precise than the current 
> > $size = ($size/1024/1024); 
> and hoping it will result in an integer…

Yes, I totally agree. I did not invent that, code like that was already
in place, but it smelled when I was looking at it, but for this release
fixing the more fundamental bugs for customers was the first priority.

Still, no excuse, that has to change eventually, I remember that I
wanted to convert it down to M and call DM with $sizeM, but got lost in
perl string conversion and kept the "old way".

So this will change eventually, if you can contribute a fix[1], that
would be great. In general I like perl as much as visual basic, so any
contribution is highly appreciated ;-).

Regards, rck

[1] https://github.com/LINBIT/drbdmanage-proxmox/

More information about the drbd-user mailing list