Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.
On Wed, Feb 25, 2009 at 02:20:45PM +0100, GAUTIER Hervé wrote: > > > ok. > > first, this is NOT a problem. > > it is just an "unexpected message". > > no harm done. > > believe me. > > I know what generates that message. > > > > This is only cosmetic. > > > > if using the older userland against the newer module, > > this had been expected (because the older userland does not expect the > > sync_progress information in state answers). > > > > I thought it would not appear, when using the correct userland against > > the newer module. apparently, I'm wrong. > > thanks for persevering ;) diff --git a/user/drbdsetup.c b/user/drbdsetup.c index 5c14d33..c2d47b0 100644 --- a/user/drbdsetup.c +++ b/user/drbdsetup.c @@ -1305,6 +1305,7 @@ int generic_get_cmd(struct drbd_cmd *cm, int minor, int argc, struct drbd_nl_cfg_reply *reply; int sk_nl,rv; int ignore_minor_not_known; + int dummy; if (argc > 1) warn_print_excess_args(argc, argv, 1); @@ -1340,6 +1341,11 @@ int generic_get_cmd(struct drbd_cmd *cm, int minor, int argc, rv = cm->gp.show_function(cm,minor,reply->tag_list); + /* in case cm->packet_id == P_get_state, and the gp.show_function did + * nothing with the sync_progress info, consume it here, so it won't + * confuse users because it gets dumped below. */ + consume_tag_int(T_sync_progress, reply->tag_list, &dummy); + if(dump_tag_list(reply->tag_list)) { printf("# Found unknown tags, you should update your\n" "# userland tools\n"); -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD® and LINBIT® are registered trademarks of LINBIT, Austria. __ please don't Cc me, but send to list -- I'm subscribed