[Drbd-dev] [PATCH] compat: make spaas url configurable

[kvaps]

Yeah. There are some discussions about the needs for this change:
- https://github.com/LINBIT/saas/pull/1#issuecomment-1152117095
- https://github.com/piraeusdatastore/piraeus-operator/issues/315

In short: we're running SPAAS locally to allow our clients with isolated
environments be able to build DRBD module in their clusters without need of
spatch dependency as it adds additional 523 megabytes to every container.

> What is the purpose of this definition in the top-level Makefile? As far
as I can see, it is only needed in the other one.
>
> I guess it serves a documentation purpose, showing what command line
variables can be set. That is presumably the point of the SPAAS variable in
the top-level makefile. In that case, explicitly pass it down like the
SPAAS variable for consistency.

Yes, I just added it into the same files where the SPAAS variable is
specified.
I think it is good to have it described somewhere, but it always has a
default value and it can work without specifying it in Makefiles at all.

Best Regards,
Andrei Kvapil


On Wed, Jun 15, 2022 at 6:32 PM Joel Colledge <joel.colledge at linbit.com>
wrote:

> Thanks for the contribution. Seems like a reasonable idea to me.
>
> > diff --git a/Makefile b/Makefile
> > index 87c29518..37d7851d 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -37,6 +37,7 @@ DOCKERIMAGESTARGETS = $(addprefix
> dockerimage.,$(DOCKERIMAGES))
> >  # Use the SPAAS (spatch as a service) online service
> >  # Have this as make variable for distributions.
> >  SPAAS ?= true
> > +SPAAS_URL ?= https://drbd.io:2020
>
> What is the purpose of this definition in the top-level Makefile? As
> far as I can see, it is only needed in the other one.
>
> I guess it serves a documentation purpose, showing what command line
> variables can be set. That is presumably the point of the SPAAS
> variable in the top-level makefile. In that case, explicitly pass it
> down like the SPAAS variable for consistency.
>
> Best regards,
> Joel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linbit.com/pipermail/drbd-dev/attachments/20220616/ac619957/attachment.htm>