[Drbd-dev] [PATCH] compat: make spaas url configurable
Joel Colledge
joel.colledge at linbit.com
Wed Jun 15 18:32:48 CEST 2022
Thanks for the contribution. Seems like a reasonable idea to me.
> diff --git a/Makefile b/Makefile
> index 87c29518..37d7851d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -37,6 +37,7 @@ DOCKERIMAGESTARGETS = $(addprefix dockerimage.,$(DOCKERIMAGES))
> # Use the SPAAS (spatch as a service) online service
> # Have this as make variable for distributions.
> SPAAS ?= true
> +SPAAS_URL ?= https://drbd.io:2020
What is the purpose of this definition in the top-level Makefile? As
far as I can see, it is only needed in the other one.
I guess it serves a documentation purpose, showing what command line
variables can be set. That is presumably the point of the SPAAS
variable in the top-level makefile. In that case, explicitly pass it
down like the SPAAS variable for consistency.
Best regards,
Joel
More information about the drbd-dev
mailing list