[Drbd-dev] [RFC PATCH 02/34] block: introduce and use bio_new

Chaitanya Kulkarni Chaitanya.Kulkarni at wdc.com
Thu Jan 28 09:34:28 CET 2021


On 1/27/21 11:27 PM, Damien Le Moal wrote:

+
+       bio_set_dev(bio, bdev);
+       bio->bi_iter.bi_sector = sector;
+       bio_set_op_attrs(bio, op, op_flags);


This function is obsolete. Open code this.


And that also mean that you could remove one argument to bio_new(): combine op
and op_flags into "unsigned int opf"



I did that initially but kept it separate for RFC, that is much easier than having

an extra arg, will change it in V1.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linbit.com/pipermail/drbd-dev/attachments/20210128/af5af6f5/attachment-0001.htm>


More information about the drbd-dev mailing list