<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<div class="moz-cite-prefix">On 1/27/21 11:27 PM, Damien Le Moal wrote:<br>
</div>
<blockquote type="cite" cite="mid:BL0PR04MB6514DBA7EDB8EC87A1C20871E7BA9@BL0PR04MB6514.namprd04.prod.outlook.com">
<blockquote type="cite" style="color: #007cff;">
<blockquote type="cite" style="color: #007cff;">
<pre class="moz-quote-pre" wrap="">+
+ bio_set_dev(bio, bdev);
+ bio->bi_iter.bi_sector = sector;
+ bio_set_op_attrs(bio, op, op_flags);
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">This function is obsolete. Open code this.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">And that also mean that you could remove one argument to bio_new(): combine op
and op_flags into "unsigned int opf"
</pre>
</blockquote>
<p><font face="monospace">I did that initially but kept it separate for RFC, that is much easier than having</font></p>
<p><font face="monospace">an extra arg, will change it in V1.</font><br>
</p>
</body>
</html>