[Drbd-dev] [PATCH 09/10] treewide: Remove uninitialized_var() usage
jgg at ziepe.ca
Thu Jun 4 15:23:06 CEST 2020
On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote:
> Using uninitialized_var() is dangerous as it papers over real bugs
> (or can in the future), and suppresses unrelated compiler warnings
> (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> either simply initialize the variable or make compiler changes.
> I preparation for removing the macro, remove all remaining
> needless uses with the following script:
> git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \
> xargs perl -pi -e \
> s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;'
> drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid
> pathological white-space.
> No outstanding warnings were found building allmodconfig with GCC 9.3.0
> for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64,
> alpha, and m68k.
At least in the infiniband part I'm confident that old gcc versions
will print warnings after this patch.
As the warnings are wrong, do we care? Should old gcc maybe just -Wno-
Otherwise the IB bits look ok to me
Acked-by: Jason Gunthorpe <jgg at mellanox.com>
More information about the drbd-dev