[Drbd-dev] [PATCH 00/10] Remove uninitialized_var() macro
Kees Cook
keescook at chromium.org
Thu Jun 4 16:27:42 CEST 2020
On Thu, Jun 04, 2020 at 09:26:58AM +0200, Sedat Dilek wrote:
> On Thu, Jun 4, 2020 at 5:33 AM Nathan Chancellor
> <natechancellor at gmail.com> wrote:
> >
> > On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote:
> > > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > > (or can in the future), and suppresses unrelated compiler warnings
> > > (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> > > either simply initialize the variable or make compiler changes.
> > >
> > > As recommended[2] by[3] Linus[4], remove the macro.
> > [...]
> > For the series, consider it:
> >
> > Tested-by: Nathan Chancellor <natechancellor at gmail.com> [build]
> [...]
>
> I tried with updated version (checkpatch) of your tree and see no
> (new) warnings in my build-log.
>
> Feel free to add my...
>
> Tested-by: Sedat Dilek <sedat.dilek at gmail.com>
Awesome! Thank you both! :)
--
Kees Cook
More information about the drbd-dev
mailing list