[Drbd-dev] [PATCH 00/17] lru_cache: checkpatch clean ups

Lars Ellenberg lars.ellenberg at linbit.com
Mon Oct 2 15:13:36 CEST 2017

On Mon, Oct 02, 2017 at 09:33:59AM +1100, Tobin C. Harding wrote:
> Checkpatch clean ups for lib/lru_cache.c
> This patch set is intended to test the waters as to whether DRBD
> wants/accepts checkpatch clean ups. I know that many maintainers
> consider such patches as code churn.

I'd consider them such.
Probably nothing wrong with those patches, really,
though I did not look very closely.

I'd maybe do this kind of cleanup IF I was to touch the code anyways.

> I am taking a look at the DRBD code after bumping into Brian at OSSNA in LA.
> If you do want/like checkpatch fixes I am happy to do so for drivers/block/drbd/* while I look
> around the code base.
> I don't know which tree you guys are working off.
> This series applies on top of Linus' development
> tree, commit:
> a8c964eacb21288b2dbfa9d80cee5968a3b8fb21

Our "upstream" is out-of-tree still,
and tries to be compatible with a wide range of kernel.org tree versions.
We recently move the public master to github.com/LINBIT/drbd-8.4/
and it looks in some parts quite different from the in kernel code,
for compatilibity reasons.

But for this kind of cleanup stuff,
kernel.org master is the right reference, yes.

As I said, I don't care much for "no-op" commits, and even if I'd take
them, I'd fold them all into one "fixes for checkpatch complaints".

But don't let that keep you from "looking around the code base",
maybe you still spot things that actually need fixing
or can otherwise be improved.  It's not that we don't like contributors,
it's just that contributing "white-space only changes" to C code won't
earn you much points in my book ;-)



More information about the drbd-dev mailing list