[Drbd-dev] [PATCH] [RFC] drbd: do not record build details

[Roland Kammerer]

On Mon, Jul 17, 2017 at 09:49:58PM +0200, Bernhard M. Wiedemann wrote:
> such as user, hostname and build date
> to allow reproducible builds
> 
> See https://reproducible-builds.org/ for why this matters.
> 
> ---
> Note: There are plenty alternatives to this patch
> but this one was the easiest to write for me
> to have a fully reproducible build
> and is meant as a base for discussing how to fix this part.
> E.g. it could involve a [ -z "${SOURCE_DATE_EPOCH" ] || ...
> ---
>  drbd/Kbuild | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drbd/Kbuild b/drbd/Kbuild
> index 2d1b4d0..08def4e 100644
> --- a/drbd/Kbuild
> +++ b/drbd/Kbuild
> @@ -134,5 +134,5 @@ $(obj)/drbd_buildtag.c: $(filter-out drbd_buildtag.o,$(drbd-y))
>  		echo >&2 "Your DRBD source tree is broken. Unpack again.";      \
>  		exit 1;								\
>  	fi ;									\
> -	echo -e "\t\t\" build by $$USER@$$HOSTNAME, `date "+%F %T"`\";\n}";	\
> +	echo -e "\t\t\" reproducible build\";\n}";	\
>  	mv -f $@.new $@

Okay, we are talking about oot drbd, right?

I'm a big fan of reproducible builds, but only as long as it does not
break very useful information for us when we actually look at customer
installations. In that case it IMO does break that.

Again, I totally understand what the reproducible build project tries to
achieve, and it is important, but why isn't that just a vendor-patch for
the distribution you care about like the Debian guys do it?

Regards, rck