[Drbd-dev] [PATCH] drbd: use bitmap_weight()

Akinobu Mita akinobu.mita at gmail.com
Sun Mar 22 03:11:41 CET 2015

2015-03-21 0:14 GMT+09:00 Lars Ellenberg <lars.ellenberg at linbit.com>:
> On Sat, Mar 14, 2015 at 10:12:56AM +0900, Akinobu Mita wrote:
>> Use bitmap_weight to count the total number of bits set in bitmap.
>> This change just simplifies the code a bit.
> "Simplifies", not sure about that, but ok, maybe.
> For the "bm_set_full_words_within_one_page", I disagree.
> I think it is more cpu cache friendly to hweight_long then set to ~0UL
> each word in turn, than to first bitmap_weight() all words, then
> bitmap_fill() all words.

I see. I'll remove the change in bm_set_full_words_within_one_page().

> Thanks,
>         Lars Ellenberg
> BTW, you swapped names and email addresses of phil and me.  Are those
> listed incorrectly somewhere, or was that just a mishap on your part?

It's just my mistake.  I copied your names from MAINTAINERS, but it
doesn't list your email addresses then I incorrectly swapped while
retrieving email addrsses from git log.

More information about the drbd-dev mailing list