[Drbd-dev] [PATCH] DRBD8.0: Fix to ensure we dont send barrier when connecting

Graham, Simon Simon.Graham at stratus.com
Sun Jan 27 03:54:21 CET 2008

The new "send-barrier-as-soon-as-possible" functionality has a small
problem in that the CREATE_BARRIER flag can get set in the mdev when it
is not connected - this causes a barrier request to be sent incorrectly
when the first write is done after reconnecting which in turn leads to
the two sides getting out of sync with respect to expected barrier

The attached patch addresses this in a couple of ways:

1. Don't call queue_barrier in about_to_complete_local_write if the
connection is not up
2. Ensure the flag is clear at the end of _tl_clear
3. Make sure the flag is cleared if set when connecting

Some of this is belt-and-braces - 1 and 2 should be enough, but just in
case, I thought it was worth adding 3.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Make-sure-we-dont-set-CREATE_BARRIER-flag-when-conne.patch
Type: application/octet-stream
Size: 2568 bytes
Desc: 0002-Make-sure-we-dont-set-CREATE_BARRIER-flag-when-conne.patch
Url : http://lists.linbit.com/pipermail/drbd-dev/attachments/20080126/498e5241/0002-Make-sure-we-dont-set-CREATE_BARRIER-flag-when-conne.obj

More information about the drbd-dev mailing list