[DRBD-user] Problems with diskless mode (OOM killer)

[Lars Ellenberg]

On Fri, Apr 27, 2007 at 09:33:54AM +0200, Goswin von Brederlow wrote:
> Hi,
> 
> I seem to have problems when drbd goes into diskless mode, i.e. when
> the physical disk on the primary fails or is detached. At first
> everything works but after some I/O the OOM killer goes wild and kills
> everything that moves.
> 
> I'm using drbd 0.7 on a 2.6.19.2 xen kernel, probably not a well
> tested combination.
> 
> Has anyone else experienced or tested a disk failure on the primary
> node andgot it working? Or the same effect?

oops.
I found and fixed this in 8.x, but aparently we forgot to
backport the fix to 0.7 :(

I'm not sure whether this is all there is to it,
but at least this fixes the bio leak in Diskless mode.


Index: drbd_req.c
===================================================================
--- drbd_req.c	(revision 2863)
+++ drbd_req.c	(working copy)
@@ -294,6 +294,8 @@
 				 * local io stack.
 				 */
 				local = 0;
+				bio_put(req->private_bio);
+				req->private_bio = NULL;
 				dec_local(mdev);
 			}
 		}

-- 
: Lars Ellenberg                            Tel +43-1-8178292-0  :
: LINBIT Information Technologies GmbH      Fax +43-1-8178292-82 :
: Vivenotgasse 48, A-1120 Vienna/Europe    http://www.linbit.com :
__
please use the "List-Reply" function of your email client.