Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.
> > However, there are no zeroes anywhere else in the file except at the > > end of every sequence. > > > > I guess it is safe to conclude that your theory is right. The file > > does not appear to really be corrupted. The TrimTester tool is > > reporting a false positive. > > > > --Eric > > > I think you mentioned that you had at least one C++ consultant look at the > source code of the TrimTester tool, and that it had even been reviewed by > Samsung engineers before, and that is the part that I find most worrying. > Someone of those people should have seen immediately that the code looks > evidently suspicious in more than just a few places, and should either have > investigated or at least should have pointed out that the code may be > flawed. > I agree completely. It may have boiled down to motivation. Those first two guys were working essentially gratis and I think they just gave it a cursory once-over. The third guy was a /paid/ consultant. He saw the problem immediately, fixed it, and committed the changes to github. You get what you pay for. 😉 -Eric