Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.
On Sun, Jun 28, 2015 at 01:20:46PM +0200, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring at users.sourceforge.net>
> > Date: Wed, 19 Nov 2014 13:33:32 +0100
> >
> > The lc_destroy() function tests whether its argument is NULL and then
> > returns immediately. Thus the test around the call is not needed.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
> > ---
> > drivers/block/drbd/drbd_nl.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
> > index 1cd47df..0bcb3e0 100644
> > --- a/drivers/block/drbd/drbd_nl.c
> > +++ b/drivers/block/drbd/drbd_nl.c
> > @@ -1115,8 +1115,7 @@ static int drbd_check_al_size(struct drbd_device *device, struct disk_conf *dc)
> > lc_destroy(n);
> > return -EBUSY;
> > } else {
> > - if (t)
> > - lc_destroy(t);
> > + lc_destroy(t);
> > }
> > drbd_md_mark_dirty(device); /* we changed device->act_log->nr_elemens */
> > return 0;
> >
>
> Would you like to integrate this update suggestion
> into another source code repository?
Hi Markus,
it is already in our public repo[1]... From there it will eventually hit
mainline.
Regards, rck
[1] http://git.linbit.com/gitweb.cgi?p=drbd-9.0.git;a=commit;h=3980c5fe1dd29cb6ab1cc4c6e34e915d7c1741e0