[DRBD-user] [PATCH v5 01/11] block: make generic_make_request handle arbitrarily sized bios

Martin K. Petersen martin.petersen at oracle.com
Mon Aug 10 18:40:52 CEST 2015

Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.

>>>>> "Ming" == Ming Lin <mlin at kernel.org> writes:


Ming> I also prefer using MAX_BIO_SECTORS.  Otherwise, we may have non
Ming> page size aligned splits.

This does not matter for write same and discard since there is only a
single logical block of payload. Also, given limitations in SATA we're
always issuing 2GB-32KB sized discards. Rounding those down to an even
1GB would impact performance.

I am sympathetic to wanting to issue I/Os that are aligned to powers of
two. But for most devices this matters little since the additional cost
is limited to misaligned head and tail blocks.

One thing that may be worth considering is switching bi_size from bytes
to blocks for REQ_FS. That would give us some headroom without
increasing bi_size beyond 32 bits. But I'm not entirely sure it's worth
the pain.

Martin K. Petersen	Oracle Linux Engineering

More information about the drbd-user mailing list