[DRBD-user] [PATCH] drivers:block: Remove unneeded if statement below switch in drbd_nl.c

Nicholas Krause xerofoify at gmail.com
Sun Nov 30 23:34:55 CET 2014

Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.

Removes unneeded if statement before switch statemnt in the file, drbd_nl.c
for the function,  setup_khelper_env. This if statement is being removed due
to after running git blame on the file, finding out the comment is over three
years old and likely fixed by a newer version of the code written in the time 
since the comment was written.

Signed-off-by: Nicholas Krause <xerofoify at gmail.com>
 drivers/block/drbd/drbd_nl.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 1cd47df..ac6ca44 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -298,10 +298,6 @@ static void setup_khelper_env(struct drbd_connection *connection, char **envp)
 	char *afs;
-	/* FIXME: A future version will not allow this case. */
-	if (connection->my_addr_len == 0 || connection->peer_addr_len == 0)
-		return;
 	switch (((struct sockaddr *)&connection->peer_addr)->sa_family) {
 	case AF_INET6:
 		afs = "ipv6";

More information about the drbd-user mailing list