[DRBD-user] [PATCH] drbd: Remove fix me statements

Nick Krause xerofoify at gmail.com
Wed Jul 23 17:45:13 CEST 2014

Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.


On Wed, Jul 23, 2014 at 8:27 AM, Bjørn Mork <bjorn at mork.no> wrote:
> Nicholas Krause <xerofoify at gmail.com> writes:
>
>> This removes no longer needed fix me statements
>
> If you claim that they no longer are needed then I expect you to explain
> what's changed since they were added.
>
>> as the spinlocks
>> are needed to protect against other users of the list accessing
>>  it when items on it are being moved off it.
>
> Yes, that's most likely why the locking is there.
>
> The FIXMEs on the other hand, are probably there to tell you that it
> would be nice to get rid of the double locking.  I don't see that
> changing.
>
>
> Bjørn
>

Bjorn,
Can we remove the double locking  as you are stating or do  we still need it
to protect against the list being accessed  as the list seems to be moving
to a spinlock protected list.
Cheers Nick



More information about the drbd-user mailing list