Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.
On Wed, Apr 03, 2013 at 04:00:31PM +0800, Chen Gang wrote: > Hello maintainers: > > when you have time, please help to check this patch whether is OK. > > thanks. Thanks. It has already been queued in: http://git.kernel.dk/?p=linux-block.git;a=commit;h=0b6ef4164f50698eee536903d69d086add1a7889 > On 2013年03月27日 14:56, Chen Gang wrote: > > > > need remove it, or always return -EBUSY. > > it is found by compiler with 'EXTRA_CFLAG=-W'. > > > > Signed-off-by: Chen Gang <gang.chen at asianux.com> > > --- > > drivers/block/drbd/drbd_actlog.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c > > index 6afe173..6608076 100644 > > --- a/drivers/block/drbd/drbd_actlog.c > > +++ b/drivers/block/drbd/drbd_actlog.c > > @@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i) > > if (unlikely(tmp != NULL)) { > > struct bm_extent *bm_ext = lc_entry(tmp, struct bm_extent, lce); > > if (test_bit(BME_NO_WRITES, &bm_ext->flags)) { > > - if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags)); > > + if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags)) > > return -EBUSY; > > return -EWOULDBLOCK; > > } > >