Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.
the openSUSE xen kernel http://download.opensuse.org/repositories/Kernel:/HEAD/openSUSE_11.1/x86_64/kernel-xen-devel-2.6.31.1-3.1.x86_64.rpm http://download.opensuse.org/repositories/Kernel:/HEAD/openSUSE_11.1/noarch/kernel-source-2.6.31.1-3.1.noarch.rpm indeed the error also occures in 8.3.2 but I can confirm to you 8.3.3RC3 has the same probleem. mfg, jeroen Lars Ellenberg wrote: > On Mon, Oct 05, 2009 at 01:21:07PM +0200, Jeroen Groenewegen van der Weyden wrote: > >> Hello, >> >> I tried to compile drbd 8.3.3RC against kernel source 2.6.31.1-3, I get >> a compile error. >> > > uhm. > what exact kernel source is that? > distro? kernel.org? > > Did you (or those guys responsible for your kernel source) > notice this upstream commit? > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=0f78ab9899e9d6acb09d5465def618704255963b;hp=e00c54c36ac2024c3a8a37432e2e2698ff849594 > > >> Sources obtained from http://oss.linbit.com/drbd/8.3/drbd-8.3.3rc3.tar.gz >> >> ++++++++++ compile error +++++++++++ >> >> CC [M] /root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.o >> > ^^^^^^^^^^ > you say its 8.3.3rc, yet it is in drbd-8.3.2? > > >> /root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c: In function >> â_drbd_start_io_acctâ: >> /root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c:64: error: lvalue >> required as increment operand >> /root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c: In function >> â_drbd_end_io_acctâ: >> /root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.c:86: error: lvalue >> required as decrement operand >> make[6]: *** [/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd/drbd_req.o] >> Error 1 >> make[5]: *** [_module_/root/drbd-8.3.2/dist/BUILD/drbd-8.3.2/drbd] Error 2 >> make[4]: *** [sub-make] Error 2 >> make[3]: *** [all] Error 2 >> >> ++++++++++ compile error +++++++++++ >> >> >> >> solution >> >> based on this patch but only for lines 64 and 86 >> >> "diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c >> >> index cbdc257..0656cf1 100644 >> --- a/drivers/block/drbd/drbd_req.c >> +++ b/drivers/block/drbd/drbd_req.c >> @@ -42,7 +42,7 @@ static void _drbd_start_io_acct(struct drbd_conf *mdev, struct drbd_request *req >> part_stat_inc(cpu, &mdev->vdisk->part0, ios[rw]); >> part_stat_add(cpu, &mdev->vdisk->part0, sectors[rw], bio_sectors(bio)); >> part_stat_unlock(); >> - mdev->vdisk->part0.in_flight++; >> + mdev->vdisk->part0.in_flight[rw]++; >> } >> > > ... > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linbit.com/pipermail/drbd-user/attachments/20091005/174ff126/attachment.htm>