Note: "permalinks" may not be as permanent as we would like,
direct links of old sources may well be a few messages off.
On Tue, Jul 04, 2006 at 12:31:46PM +0200, Lars Ellenberg wrote: > / 2006-07-03 19:47:55 +0200 > \ Guido Guenther: > > Hi, > > according to block/ioctl.c drbd_ioctl() is supposed to return -ENOCTLCMD > > instead of -EINVAL when it doesn't handle that specific ioctl: > > > > /* Most of the generic ioctls are handled in the normal fallback path. > > This assumes the blkdev's low level compat_ioctl always returns > > ENOIOCTLCMD for unknown ioctls. */ > > > > If we don't do this all ioctl's like BLKGETSIZE64 and friends return > > EINVAL which makes drbd almost unusable with a 32bit userspace on e.g. > > amd64 (except for the trivial case where you create the fs direcly on > > the /dev/drbd? device). With this one liner partitioning and lvm > > work as expected, please apply: > > um. how do you partition drbd ?? Actually I don't (only using LVM) - but even starting cfdisk failed due to the missing BLKGETSIZE64 and friends. > thanks for the heads up... > unfortunately this patch does not work generically, > it would return ENOIOCTLCMD to user space for the non ->compat_ioctl case. > which is not allowed. > I fixed it in the drbd_compat_ioctl wrapper. ...yes obviosly the better place. Thanks, -- Guido