[PATCH 16/26] block: move the io_stat flag setting to queue_limits

Damien Le Moal dlemoal at kernel.org
Tue Jun 11 10:09:45 CEST 2024


On 6/11/24 2:19 PM, Christoph Hellwig wrote:
> Move the io_stat flag into the queue_limits feature field so that it
> can be set atomically and all I/O is frozen when changing the flag.

Why a feature ? It seems more appropriate for io_stat to be a flag rather than
a feature as that is a block layer thing rather than a device characteristic, no ?

> 
> Simplify md and dm to set the flag unconditionally instead of avoiding
> setting a simple flag for cases where it already is set by other means,
> which is a bit pointless.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

-- 
Damien Le Moal
Western Digital Research



More information about the drbd-dev mailing list