[Drbd-dev] [PATCH net-next 03/10] genetlink: remove userhdr from struct genl_info

Johannes Berg johannes at sipsolutions.net
Wed Aug 9 22:59:47 CEST 2023


On Wed, 2023-08-09 at 11:26 -0700, Jakub Kicinski wrote:
> Only three families use info->userhdr and fixed headers
> are discouraged for new families. So remove the pointer
> from struct genl_info to save some space. Compute
> the header pointer at runtime. Saved space will be used
> for a family pointer in later patches.

Seems fine to me, but I'm not sure I buy the rationale that it's for
saving space - it's a single pointer on the stack? I'd probably argue
the computation being pointless for basically everyone except for a
handful users?

Reviewed-by: Johannes Berg <johannes at sipsolutions.net>

johannes


More information about the drbd-dev mailing list