[Drbd-dev] [PATCH 0/2] Remove orphan declarations for drbd

cuigaosheng cuigaosheng1 at huawei.com
Thu Sep 22 03:27:23 CEST 2022


> PS: I think trivial fixes like this are important, but they also create
> additional maintenance burden. So if you have more of these in the
> future, maybe save them up and submit them all at once (maybe even in a
> single patch if they are related). Thanks!

Thanks for taking time to review these patches,I will try to submit such
patches all at once in the feature.Thanks for the reminder!

> Am 20.09.22 um 03:52 schrieb Gaosheng Cui:
>> This series contains a few cleanup patches, to remove a orphan
>> declaration which has been removed and some useless comments. Thanks!
>>
>> Gaosheng Cui (2):
>>    drbd: remove orphan _req_may_be_done() declaration
>>    block/drbd: remove useless comments in receive_DataReply()
>>
>>   drivers/block/drbd/drbd_receiver.c | 3 ---
>>   drivers/block/drbd/drbd_req.h      | 2 --
>>   2 files changed, 5 deletions(-)
>>
> Both patches look good to me, thanks.
>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder at linbit.com>
>
> PS: I think trivial fixes like this are important, but they also create
> additional maintenance burden. So if you have more of these in the
> future, maybe save them up and submit them all at once (maybe even in a
> single patch if they are related). Thanks!
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linbit.com/pipermail/drbd-dev/attachments/20220922/41fefc18/attachment.htm>


More information about the drbd-dev mailing list