[Drbd-dev] [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

Chaitanya Kulkarni chaitanyak at nvidia.com
Fri Apr 15 07:47:45 CEST 2022


On 4/14/22 21:52, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
> 
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder at linbit.com> [drbd]
> Acked-by: Jan Höppner <hoeppner at linux.ibm.com> [s390]
> Acked-by: Coly Li <colyli at suse.de> [bcache]
> Acked-by: David Sterba <dsterba at suse.com> [btrfs]
> ---


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>

-ck




More information about the drbd-dev mailing list