[Drbd-dev] [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

Christoph Böhmwalder christoph.boehmwalder at linbit.com
Sat Apr 9 10:15:33 CEST 2022


On 09.04.22 06:50, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
> 
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder at linbit.com> [btrfs]

I think you may have a typo there: my ACK was for drbd, not btrfs.

> Acked-by: Coly Li <colyli at suse.de> [bcache]
> ---
>   arch/um/drivers/ubd_kern.c          |  2 --
>   block/blk-core.c                    |  2 +-


More information about the drbd-dev mailing list