[Drbd-dev] [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage

Thomas Gleixner tglx at linutronix.de
Thu Jun 4 23:39:05 CEST 2020


Kees Cook <keescook at chromium.org> writes:
>> > -#define NODE_NOT_IN_PAGE_FLAGS
>> > +#define NODE_NOT_IN_PAGE_FLAGS 1
>> 
>> but if we ever lose the 1 then the above will silently compile the code
>> within the IS_ENABLED() section out.
>
> That's true, yes. I considered two other ways to do this:
>
> 1) smallest patch, but more #ifdef:
> 2) medium size, weird style:
>
> and 3 is what I sent: biggest, but removes #ifdef
>
> Any preference?



More information about the drbd-dev mailing list