[Drbd-dev] avoid compiler warning about redefined macro

Lars Ellenberg lars.ellenberg at linbit.com
Wed Jun 12 16:09:00 CEST 2019


On Wed, Jun 05, 2019 at 10:05:29AM -0600, David Butterfield wrote:
> In drbd_dax_pmem.h:35:
> -#define arch_wb_cache_pmem(A, L) do { } while (0)
> +#define arch_wb_cache_pmem(A, S) do { } while (0)
> 
> Avoid compiler warning by making the macro definition exactly match the one in
> linux/libnvdimm.h:
>     drbd_dax_pmem.h:35: warning: "arch_wb_cache_pmem" redefined

Well, it should not have to define the same macro,
so there is likely some compat ifdef missing (or just an ifndef)

also I'm pretty sure the original in our code was copy pasted from their code...

    Lars



More information about the drbd-dev mailing list