[Drbd-dev] [PATCH 04/16] block: use atomic bitops for ->queue_flags
Christoph Hellwig
hch at lst.de
Thu Nov 15 10:04:35 CET 2018
On Thu, Nov 15, 2018 at 07:55:02AM +0100, Hannes Reinecke wrote:
>> Signed-off-by: Christoph Hellwig <hch at lst.de>
>> ---
>> block/blk-core.c | 54 ++++++----------------------------------
>> block/blk-mq.c | 2 +-
>> block/blk-settings.c | 10 +++-----
>> block/blk-sysfs.c | 28 +++++++++------------
>> block/blk.h | 56 ------------------------------------------
>> include/linux/blkdev.h | 1 -
>> 6 files changed, 24 insertions(+), 127 deletions(-)
>>
> I wonder if we can't remove the 'blk_queue_flag_XXX' helpers and replace
> them with inlines ...
I'd prefer to just open code the *bit helpers as that is a lot more
reasonable. But that is quite a lot of churn, so I'll only do that if
I get previous buy-in to that idea, and preferably in a separate series.
More information about the drbd-dev
mailing list