[Drbd-dev] [PATCH 00/13] convert block layer to bioset_init()/mempool_init()
snitzer at redhat.com
Mon May 21 20:24:32 CEST 2018
On Mon, May 21 2018 at 1:37pm -0400,
Kent Overstreet <kent.overstreet at gmail.com> wrote:
> Uh, you came across as upset and paranoid to me too. Chalk it up to email? :)
Awesome. See how easy it is to make someone with purely constructive
questions and feedback come off as upset and paranoid?
The tipping point occurs when bait is set with:
"It's not like <insert complete non sequitur>".
"Let's focus on getting it reviewed, rather than pontificate on what
could potentially go all wrong with this."
Message received: less pontificating, more doing!
And here I thought that focusing on what could go wrong (across all code
touched) was review. But OK, I'm the one that made this all weird ;)
It is what it is at this point.
> I personally don't care, I have no horse in this race. This particular patch
> series wasn't my idea, Christoph wanted all these conversions done so
> bioset_create() could be deleted. If you want us to hold off on the dm patch for
> awhile until someone can get around to testing it or whatever (since I don't
> have tests for everything I pushed) that would be perfectly fine by me.
As I clarified already: this isn't about DM.
Every single data structure change in this series should be reviewed for
unforeseen alignment consequences. Jens seemed to say that is
worthwhile. Not sure if he'll do it or we divide it up. If we divide
it up a temp topic branch should be published for others to inspect.
Could be alignment hasn't been a historic concern for a bunch of the
data structures changed in this series.. if so then all we can do is fix
up any obvious potential for false sharing.
More information about the drbd-dev