[Drbd-dev] [PATCH v2] block: Change to use DEFINE_SHOW_ATTRIBUTE macro

Jens Axboe axboe at kernel.dk
Sat Dec 1 19:10:58 CET 2018

On 12/1/18 7:24 AM, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
> Signed-off-by: Yangtao Li <tiny.windzz at gmail.com>
> ---
> changes in v2:
> -Modify some function names to avoid compilation errors

The fact that your previous patch didn't even compile doesn't fill me
with a lot of confidence in the amount of diligence and testing
you apply to your patches.

Why would you send something out that you didn't even compile?

Jens Axboe

More information about the drbd-dev mailing list