[Drbd-dev] [PATCH 23/23] block: remove the discard_zeroes_data flag
hch at lst.de
hch at lst.de
Thu Mar 30 11:06:55 CEST 2017
On Tue, Mar 28, 2017 at 05:00:48PM +0000, Bart Van Assche wrote:
>
> It seems to me like the documentation in Documentation/ABI/testing/sysfs-block
> and the above code are not in sync. I think the above code will cause reading
> from the discard_zeroes_data attribute to return an empty string ("") instead
> of "0\n".
Thanks, fine with me.
>
> BTW, my personal preference is to remove this attribute entirely because keeping
> it will cause confusion, no matter how well we document the behavior of this
> attribute.
Jens, any opinion? I'd like to remove it too, but I fear it might
break things. We could deprecate it first with a warning when read
and then remove it a few releases down the road.
More information about the drbd-dev
mailing list