[Drbd-dev] [PATCH 01/25] ѕd: split sd_setup_discard_cmnd

Martin K. Petersen martin.petersen at oracle.com
Wed Apr 5 13:42:46 CEST 2017

Christoph Hellwig <hch at lst.de> writes:

> Split sd_setup_discard_cmnd into one function per provisioning type.  While
> this creates some very slight duplication of boilerplate code it keeps the
> code modular for additions of new provisioning types, and for reusing the
> write same functions for the upcoming scsi implementation of the Write Zeroes
> operation.

Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>

Minor nit: Patch header should be "sd: ..." instead of " d: ...".

Martin K. Petersen	Oracle Linux Engineering

More information about the drbd-dev mailing list