[Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages

Lars Ellenberg lars.ellenberg at linbit.com
Mon May 9 15:15:48 CEST 2016

On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote:
> The attribute 0 is never used in drbd, so let's use it as pad attribute
> in netlink messages. This minimizes the patch.
> Note that this patch is only compile-tested.
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel at 6wind.com>
> Signed-off-by: Lars Ellenberg <lars.ellenberg at linbit.com>
> ---
> v2 -> v3:
>   use 0 as padattr instead of adding new attributes


> v1 -> v2:
>  rework the patch to handle all cases
> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_'
> could be interesting so that new module won't use it. What is your
> opinion?

This was supposed to not be DRBD specific.  But it might even still
need some massaging before it was truly generic. And obviously,
it does not meet the taste of genetlink folks, to say the least :(

I don't care either way.

    Lars Ellenberg

More information about the drbd-dev mailing list