[Drbd-dev] [PATCH 07/45] bcache: use op_is_write instead of checking for REQ_WRITE
Hannes Reinecke
hare at suse.de
Mon Jun 6 08:16:44 CEST 2016
On 06/05/2016 09:31 PM, mchristi at redhat.com wrote:
> From: Mike Christie <mchristi at redhat.com>
>
> We currently set REQ_WRITE/WRITE for all non READ IOs
> like discard, flush, writesame, etc. In the next patches where we
> no longer set up the op as a bitmap, we will not be able to
> detect a operation direction like writesame by testing if REQ_WRITE is
> set.
>
> This has bcache use the op_is_write helper which will do the right
> thing.
>
> Signed-off-by: Mike Christie <mchristi at redhat.com>
> ---
> drivers/md/bcache/io.c | 2 +-
> drivers/md/bcache/request.c | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
(Could probably folded together with the two previous patches)
Reviewed-by: Hannes Reinecke <hare at suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare at suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
More information about the drbd-dev
mailing list