[Drbd-dev] [PATCH 39/45] ide cd: do not set REQ_WRITE on requests.

mchristi at redhat.com mchristi at redhat.com
Sun Jun 5 21:32:19 CEST 2016

From: Mike Christie <mchristi at redhat.com>

The block layer will set the correct READ/WRITE operation flags/fields
when creating a request, so there is not need for drivers to set the

Signed-off-by: Mike Christie <mchristi at redhat.com>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Reviewed-by: Hannes Reinecke <hare at suse.com>
 drivers/ide/ide-cd_ioctl.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/ide/ide-cd_ioctl.c b/drivers/ide/ide-cd_ioctl.c
index 474173e..5887a7a 100644
--- a/drivers/ide/ide-cd_ioctl.c
+++ b/drivers/ide/ide-cd_ioctl.c
@@ -459,9 +459,6 @@ int ide_cdrom_packet(struct cdrom_device_info *cdi,
 	   layer. the packet must be complete, as we do not
 	   touch it at all. */
-	if (cgc->data_direction == CGC_DATA_WRITE)
-		flags |= REQ_WRITE;
 	if (cgc->sense)
 		memset(cgc->sense, 0, sizeof(struct request_sense));

More information about the drbd-dev mailing list