[Drbd-dev] [CASE-23] please check potential error possibility.

[Roland Kammerer]

On Wed, Feb 24, 2016 at 10:56:18AM +0100, Roland Kammerer wrote:
> On Wed, Feb 24, 2016 at 03:44:56PM +0900, 김재헌 wrote:
> > Hi,
> > 
> > Please check following codes whether potential error or not on version:
> > 9.0.1-1.
> > 
> > 1. drbd_pause_after/drbd_resume_next
> > 
> >  - You used disk_state without array index.
> > 
> > #if 1
> >        if (other_device->disk_state[NOW] == D_DISKLESS) { // new
> > #else
> >        if (other_device->disk_state == D_DISKLESS) { // orignal code
> > #endif
> > 
> > 
> > 2. drbd_adm_dump_peer_devices/drbd_adm_dump_devices
> > 
> >  - If you run the first "goto put_result;" statement, you should meet
> > rcu_read_unlock() without rcu_read_lock().
> >  - Is it no problem?
> 
> Hi,
> 
> I think you are right in both cases, I prepared fixes, which are
> currently under review...

http://git.linbit.com/drbd-9.0.git/commitdiff/89fc34d91724c402c64e9f8cd7d7d92058abf0ed
and
http://git.linbit.com/drbd-9.0.git/commitdiff/3cd85d42444749166d04d1f8ffcea25c7e9add04

Thanks again, rck