[Drbd-dev] [PATCH 10/38] drbd: Deletion of an unnecessary check before the function call "lc_destroy"

Philipp Reisner philipp.reisner at linbit.com
Wed Nov 25 11:53:43 CET 2015

From: Markus Elfring <elfring at users.sourceforge.net>

The lc_destroy() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>
Signed-off-by: Roland Kammerer <roland.kammerer at linbit.com>

Signed-off-by: Philipp Reisner <philipp.reisner at linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg at linbit.com>
 drivers/block/drbd/drbd_nl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c
index 1eb10e2..b87fb31 100644
--- a/drivers/block/drbd/drbd_nl.c
+++ b/drivers/block/drbd/drbd_nl.c
@@ -1133,8 +1133,7 @@ static int drbd_check_al_size(struct drbd_device *device, struct disk_conf *dc)
 		return -EBUSY;
 	} else {
-		if (t)
-			lc_destroy(t);
+		lc_destroy(t);
 	drbd_md_mark_dirty(device); /* we changed device->act_log->nr_elemens */
 	return 0;

More information about the drbd-dev mailing list