[Drbd-dev] [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios

[Ming Lin]

On Mon, May 18, 2015 at 9:52 AM, Jeff Moyer <jmoyer at redhat.com> wrote:
>
>> +static struct bio *blk_bio_segment_split(struct request_queue *q,
>> +                                      struct bio *bio,
>> +                                      struct bio_set *bs)
>> +{
>
> Funny name for a function that also merges segments.  ;-)  I admit I am

I'm trying to understand ... but I didn't see it also merges segments.

> at a loss for coming up with a better name that won't overflow 80
> columns.
>
> Other than that, this looks sane.
>
> Cheers,
> Jeff