[Drbd-dev] [PATCH 01/10] block: make generic_make_request handle arbitrarily sized bios

[Ming Lin]

On Tue, May 5, 2015 at 11:48 PM, Christoph Hellwig <hch at infradead.org> wrote:
> On Tue, May 05, 2015 at 11:08:20PM -0700, Ming Lin wrote:
>> How about below incremental patch?
>
>> -
>> -             /*
>> -              * If the queue doesn't support SG gaps and adding this
>> -              * offset would create a gap, disallow it.
>> -              */
>> -             if (q->queue_flags & (1 << QUEUE_FLAG_SG_GAPS) &&
>> -                 bvec_gap_to_prev(prev, offset))
>> -                     return 0;
>
> You need to keep the explicit checks for the BLOCK_PC case, as we can't
> split those.

I'll keep it. Thanks.

>
> Otherwise it looks fine.