[Drbd-dev] [PATCH 16/19] drbd: drbd_panic_after_delayed_completion_of_aborted_request()

Philipp Reisner philipp.reisner at linbit.com
Thu Jul 30 13:21:51 CEST 2015

From: Lars Ellenberg <lars.ellenberg at linbit.com>

The only way to make DRBD intentionally call panic is to
set a disk timeout, have that trigger, "abort" some request and complete
to upper layers, then have the backend IO subsystem later complete these
requests successfully regardless.

As the attached IO pages have been recycled for other purposes
meanwhile, this will cause unexpected random memory changes.
To prevent corruption, we rather panic in that case.

Make it obvious from stack traces that this was the case by introducing

Signed-off-by: Philipp Reisner <philipp.reisner at linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg at linbit.com>
 drivers/block/drbd/drbd_worker.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index ef70e1f..93777b1 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -199,6 +199,12 @@ void drbd_peer_request_endio(struct bio *bio, int error)
+void drbd_panic_after_delayed_completion_of_aborted_request(struct drbd_device *device)
+	panic("drbd%u %s/%u potential random memory corruption caused by delayed completion of aborted local request\n",
+		device->minor, device->resource->name, device->vnr);
 /* read, readA or write requests on R_PRIMARY coming from drbd_make_request
 void drbd_request_endio(struct bio *bio, int error)
@@ -253,7 +259,7 @@ void drbd_request_endio(struct bio *bio, int error)
 			drbd_emerg(device, "delayed completion of aborted local request; disk-timeout may be too aggressive\n");
 		if (!error)
-			panic("possible random memory corruption caused by delayed completion of aborted local request\n");
+			drbd_panic_after_delayed_completion_of_aborted_request(device);
 	/* to avoid recursion in __req_mod */

More information about the drbd-dev mailing list