[Drbd-dev] [patch 6/6] drbd: use copy_highpage

Philipp Reisner philipp.reisner at linbit.com
Fri Nov 9 10:24:08 CET 2012


Thanks, I will put it in my tree today.

Best,
 Phil
> From: Akinobu Mita <akinobu.mita at gmail.com>
> Subject: drbd: use copy_highpage
> 
> Use copy_highpage() to copy from one page to another.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita at gmail.com>
> Cc: Lars Ellenberg <drbd-dev at lists.linbit.com>
> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
> ---
> 
>  drivers/block/drbd/drbd_bitmap.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff -puN drivers/block/drbd/drbd_bitmap.c~drbd-use-copy_highpage
> drivers/block/drbd/drbd_bitmap.c ---
> a/drivers/block/drbd/drbd_bitmap.c~drbd-use-copy_highpage
> +++ a/drivers/block/drbd/drbd_bitmap.c
> @@ -977,13 +977,8 @@ static void bm_page_io_async(struct bm_a
>  	bm_set_page_unchanged(b->bm_pages[page_nr]);
> 
>  	if (ctx->flags & BM_AIO_COPY_PAGES) {
> -		void *src, *dest;
>  		page = mempool_alloc(drbd_md_io_page_pool, __GFP_HIGHMEM|__GFP_WAIT);
> -		dest = kmap_atomic(page);
> -		src = kmap_atomic(b->bm_pages[page_nr]);
> -		memcpy(dest, src, PAGE_SIZE);
> -		kunmap_atomic(src);
> -		kunmap_atomic(dest);
> +		copy_highpage(page, b->bm_pages[page_nr]);
>  		bm_store_page_idx(page, page_nr);
>  	} else
>  		page = b->bm_pages[page_nr];
> _
> _______________________________________________
> drbd-dev mailing list
> drbd-dev at lists.linbit.com
> http://lists.linbit.com/mailman/listinfo/drbd-dev


More information about the drbd-dev mailing list