[Drbd-dev] [PATCH] udev rules file: skip if invoked for a subsystem other than block

Lars Ellenberg lars.ellenberg at linbit.com
Fri Mar 23 11:23:00 CET 2012


On Fri, Mar 23, 2012 at 11:08:04AM +0100, Florian Haas wrote:
> On Fri, Mar 23, 2012 at 11:04 AM, Lars Ellenberg
> <lars.ellenberg at linbit.com> wrote:
> > On Thu, Mar 22, 2012 at 01:44:36PM +0100, Florian Haas wrote:
> >> ---
> >>  scripts/drbd.rules |    4 ++++
> >>  1 files changed, 4 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/scripts/drbd.rules b/scripts/drbd.rules
> >> index 080635f..18708b7 100644
> >> --- a/scripts/drbd.rules
> >> +++ b/scripts/drbd.rules
> >> @@ -1,5 +1,7 @@
> >>  # This file contains the rules to create named DRBD devices.
> >>
> >> +SUBSYSTEM!="block", GOTO="drbd_end"
> >
> > I see what it does, and it probably is good practice,
> > or at least "polite" to do so.
> >
> > Does this actually fix anything?
> >
> > Do you have seen other devices with kernel provided device names
> > matching "drbd*" ?
> >
> > "What's the point?"
> > Am I missing something?
> 
> http://lists.linbit.com/pipermail/drbd-dev/2011-November/002007.html

Right. I remember now.
Should not happen, as the "drbdlinks" is not a "KERNEL=*" name
anymore...  But whatever. Udev voodoo.

I don't see how this can possible break things,
and apparently it fixes some. So:

Thanks :-)

	Lars



More information about the drbd-dev mailing list