[Drbd-dev] [PATCH 07/10] drbd: Remove headers from on-the-wire data structures (struct p_*)

Kyle Moffett kyle at moffetthome.net
Fri Sep 23 19:38:15 CEST 2011


Hi!

On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner at linbit.com> wrote:
> From: Andreas Gruenbacher <agruen at linbit.com>
>
> Signed-off-by: Philipp Reisner <philipp.reisner at linbit.com>
> Signed-off-by: Lars Ellenberg <lars.ellenberg at linbit.com>
> ---
>  drivers/block/drbd/drbd_int.h      |   45 ----------
>  drivers/block/drbd/drbd_main.c     |   44 +++++-----
>  drivers/block/drbd/drbd_receiver.c |  171 ++++++++++++++++++------------------
>  drivers/block/drbd/drbd_worker.c   |    2 +-

This commit is kind of borderline too-big for just a one-line commit message.

It is admittedly very simple (changing the same pointer math in ~50 places),
but it needs a bit more explanation about why it's helpful or necessary.

I *think* it's because the protocol-100 code will use a different-sized header,
but that needs to be actually explained somewhere.

Cheers,
Kyle Moffett


More information about the drbd-dev mailing list