[Drbd-dev] [PATCH] initialize tconn->peer_integrity_tfm in drbd_adm_connect()

[Thomas Zeitlhofer]

Hello Andreas,

On Mon, Jul 25, 2011 at 11:39:45AM +0200, Andreas Gruenbacher wrote:
> Thomas,
> 
> On Monday 25 July 2011 01:38:48 Thomas Zeitlhofer wrote:
> > The support for data-integrity-alg seems to be broken with drbd-8.4.0.
> > E.g., when trying to resync, the SyncTarget hits:
> > 
> >    ASSERTION IS_ALIGNED(data_size, 512) FAILED in read_in_block
> >    error receiving RSDataReply, e: -5 l: 126996! read_in_block
> > 
> > This is caused by an uninitialized tconn->peer_integrity_tfm. Therefore,
> > the digest data is not used/removed at the receiver which leads to
> > additional 20 bytes that trigger the assertion above.
> 
> thanks for tracking this down.  Your analysis and the fix are correct.  As it 
> happens, we also ran into this bug here meanwhile.  

I stumbled upon this bug and was already wondering that it has not been
discussed so far.

> Here is what we did to address it:
> 
>   http://git.drbd.org/?p=drbd-8.4.git;a=commit;h=4811eceb393c274f94bfd8926e714d6271cf1f57
> 
> The two fixes are slightly different, but both should do the job.
> Sorry for not letting you know of our fix in time.
>
> The master branch in http://git.drbd.org/?p=drbd-8.4.git contains a few 
> additional minor fixes.

Thanks for the information - the public git repository did not show any
commits since the 8.4.0 release, so I just had a look at this issue.

Best Regards

Thomas