[Drbd-dev] [patch 4/4] drivers/block/drbd/drbd_main.c: fix error path
Philipp Reisner
philipp.reisner at linbit.com
Thu Oct 28 10:22:48 CEST 2010
Hi Jens,
The patch is obviously correct.
Should I pick it up (and send you a pull req (later))?
Are you going to pick it up directly?
Best,
Phil
> From: Nicolas Kaiser <nikai at nikai.net>
>
> Failure to create drbd_ee_mempool appears not to get checked. Looks like
> a copy-and-paste problem to me.
>
> Signed-off-by: Nicolas Kaiser <nikai at nikai.net>
> Cc: Lars Ellenberg <drbd-dev at lists.linbit.com>
> Cc: Philipp Reisner <philipp.reisner at linbit.com>
> Cc: Jens Axboe <axboe at kernel.dk>
> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
> ---
>
> drivers/block/drbd/drbd_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN
> drivers/block/drbd/drbd_main.c~drivers-block-drbd-drbd_mainc-fix-error-pat
> h drivers/block/drbd/drbd_main.c ---
> a/drivers/block/drbd/drbd_main.c~drivers-block-drbd-drbd_mainc-fix-error-p
> ath +++ a/drivers/block/drbd/drbd_main.c
> @@ -2982,7 +2982,7 @@ static int drbd_create_mempools(void)
>
> drbd_ee_mempool = mempool_create(number,
> mempool_alloc_slab, mempool_free_slab, drbd_ee_cache);
> - if (drbd_request_mempool == NULL)
> + if (drbd_ee_mempool == NULL)
> goto Enomem;
>
> /* drbd's page pool */
> _
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
More information about the drbd-dev
mailing list