[Drbd-dev] don't memset null pointer

Philipp Reisner philipp.reisner at linbit.com
Mon Nov 5 14:07:48 CET 2007


On Monday 05 November 2007 13:04:49 Stanislaw Gruszka wrote:
> Hi, this is trivial fix for memset null pointer:
>
> diff --git a/drbd/lru_cache.c b/drbd/lru_cache.c
> index a3171b6..37ab276 100644
> --- a/drbd/lru_cache.c
> +++ b/drbd/lru_cache.c
> @@ -57,8 +57,8 @@ struct lru_cache *lc_alloc(const char *name, unsigned int
> e_count, bytes *= e_count;
>  	bytes += sizeof(struct lru_cache);
>  	lc     = vmalloc(bytes);
> -	memset(lc, 0, bytes);
>  	if (lc) {
> +		memset(lc, 0, bytes);
>  		INIT_LIST_HEAD(&lc->in_use);
>  		INIT_LIST_HEAD(&lc->lru);
>  		INIT_LIST_HEAD(&lc->free);

Thanks!

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Vivenotgasse 48, 1120 Vienna, Austria        http://www.linbit.com :


More information about the drbd-dev mailing list