[Drbd-dev] Bug?

[Milind Dumbare]

Hi,
First of all to tell I am working on x86_64 machine.

The structure ioctl_get_config has size 576(bytes) and its padded with
int (4byte) so it makes 580 (bytes). And compiler will align it to 584
(bytes), as 580 is not completely divisible by 8 while 584 is.

So don't you think drbd_sizeof_sanity_check.c:21 should be

        SZO(struct ioctl_get_config,    576)
rather than
        SZO(struct ioctl_get_config,    580)

after removing padding. It will also be alligned on 32 bit compilers.

-Thanks
-Milind