[Drbd-dev] DRBD-8: Disk I/O failure during processing of attach command causes panic in drbd_chk_io_error

[Philipp Reisner]

Am Dienstag, 8. August 2006 16:47 schrieb Graham, Simon:
> The drbd_ioctl_set_disk() routine allocates a new backing_dev structure
> but does not attach it to the mdev until after the meta data has been
> successfully read - if any disk error (such as a read of the meta data
> area failing) occurs during this process, the low level routines such as
> drbd_al_read_tr call drbd_chk_io_error which assumes that mdev->bc has
> been initialized, leading to a panic.
>
> Not sure what the right answer is here, but perhaps drbd_chk_io_error()
> and drbd_io_error() need to be passed the backing_dev* as a parameter
> instead of reading it from mdev->bc?
>

I think it is sufficient to fail the attach ioctl. This is done by the
return value of drbd_al_read_log(). calling drbd_chk_io_error() or
drbd_io_error() was completely missplaced there.

Thanks for pointing this out!

The mini patch:
http://lists.linbit.com/pipermail/drbd-cvs/2006-August/001181.html

-Philipp
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria    http://www.linbit.com :